Change hookspec to migration parameters for generate_pdf to options object

Breaking change for PDF rendering plugins (although none are known to exist).
This provides better separation of Ghostscript specific concerns from
the generic plugin interface.
This commit is contained in:
James R. Barlow
2023-09-20 15:40:18 -07:00
parent b2cbbf0099
commit c77ae4b34c
7 changed files with 19 additions and 28 deletions
+2 -3
View File
@@ -20,15 +20,14 @@ def run_append_stderr(*args, **kwargs):
@hookimpl
def generate_pdfa(pdf_pages, pdfmark, output_file, compression, pdf_version, pdfa_part):
def generate_pdfa(pdf_pages, pdfmark, output_file, context, pdf_version, pdfa_part):
with patch('ocrmypdf._exec.ghostscript.run_polling_stderr') as mock:
mock.side_effect = run_append_stderr
ghostscript.generate_pdfa(
pdf_pages=pdf_pages,
pdfmark=pdfmark,
output_file=output_file,
compression=compression,
color_conversion_strategy='LeaveColorUnchanged',
context=context,
pdf_version=pdf_version,
pdfa_part=pdfa_part,
progressbar_class=None,
+2 -3
View File
@@ -22,15 +22,14 @@ def run_rig_args(args, **kwargs):
@hookimpl
def generate_pdfa(pdf_pages, pdfmark, output_file, compression, pdf_version, pdfa_part):
def generate_pdfa(pdf_pages, pdfmark, output_file, context, pdf_version, pdfa_part):
with patch('ocrmypdf._exec.ghostscript.run_polling_stderr') as mock:
mock.side_effect = run_rig_args
ghostscript.generate_pdfa(
pdf_pages=pdf_pages,
pdfmark=pdfmark,
output_file=output_file,
compression=compression,
color_conversion_strategy='LeaveColorUnchanged',
context=context,
pdf_version=pdf_version,
pdfa_part=pdfa_part,
progressbar_class=None,
+2 -3
View File
@@ -17,15 +17,14 @@ def raise_gs_fail(*args, **kwargs):
@hookimpl
def generate_pdfa(pdf_pages, pdfmark, output_file, compression, pdf_version, pdfa_part):
def generate_pdfa(pdf_pages, pdfmark, output_file, context, pdf_version, pdfa_part):
with patch('ocrmypdf._exec.ghostscript.run_polling_stderr') as mock:
mock.side_effect = raise_gs_fail
ghostscript.generate_pdfa(
pdf_pages=pdf_pages,
pdfmark=pdfmark,
output_file=output_file,
compression=compression,
color_conversion_strategy='LeaveColorUnchanged',
context=context,
pdf_version=pdf_version,
pdfa_part=pdfa_part,
progressbar_class=None,
+2 -3
View File
@@ -23,7 +23,7 @@ def generate_pdfa(
pdf_pages,
pdfmark,
output_file,
compression,
context,
pdf_version,
pdfa_part,
stop_on_soft_error,
@@ -34,8 +34,7 @@ def generate_pdfa(
pdf_pages=pdf_pages,
pdfmark=pdfmark,
output_file=output_file,
compression=compression,
color_conversion_strategy='LeaveColorUnchanged',
context=context,
pdf_version=pdf_version,
pdfa_part=pdfa_part,
progressbar_class=None,