From d0d804862102df7140ee16975014bf4858be9072 Mon Sep 17 00:00:00 2001
From: Jim Barlow <jim@purplerock.ca>
Date: Fri, 17 Oct 2014 17:28:31 -0700
Subject: [PATCH] Comments

---
 src/ocrpage.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/ocrpage.py b/src/ocrpage.py
index 13188c60..1cb07de6 100755
--- a/src/ocrpage.py
+++ b/src/ocrpage.py
@@ -217,10 +217,14 @@ def unpack_with_pdftoppm(
 
     args_pdftoppm.extend([str(input_file)])
 
+    # Ask pdftoppm to write the binary output to stdout; therefore set
+    # universal_newlines=False
     p = Popen(args_pdftoppm, close_fds=True, stdout=open(output_file, 'wb'),
               stderr=PIPE, universal_newlines=False)
     _, stderr = p.communicate()
     if stderr:
+        # Because universal_newlines=False, stderr is bytes(), so we must
+        # manually convert it to str for logging
         from codecs import iterdecode
         with logger_mutex:
             logger.error(iterdecode(stderr, sys.getdefaultencoding(),